[Opensource] Bug sending Job completion notices

[Ken Chow]

OK, but shouldn't success be set to false if (ex != null). As the code
current stands, if the job fails with a Exception, an event will be
generated with success=true. Therefore, if I had removed myself from getting
notified on successful SYSERROR events, I would never receive any
notification when a job fails with an Exception.

Also, since the "Job XXX Completed" email is sent via u.notify() instead of
the Event subsystem, I assume there is no easy way to disable these emails
via a configuration option.

Ken
kckc at shaw.ca
----- Original Message -----
From: "Michael Rimov" <rimovm at centercomp.com>
To: <opensource at jcorporate.com>
Sent: Friday, February 28, 2003 7:09 PM
Subject: Re: [Opensource] Bug sending Job completion notices


> At 01:01 AM 2/28/2003 -0800, you wrote:
> >When registering a user with email validation enabled for Expresso 5.0.3,
I
> >noticed that a "System Error" email is always sent in addition to the
"Job X
> >Completed" email. The contents of both emails are the same and state that
> >the "Registration Email Validation" job succeeded. I tracked down the
source
> >of the "System Error" email to the finish(String msg, Exception ex)
method
> >in com.jcorporate.expresso.core.job.Job.java and found that:
> >
> >    new Event(dbName, "SYSERROR", mailmsg.toString(), success);
>
>
> Ken,
>
> Actually, this code is correct.  To better define things, the Event
Handler
> checks to see if you want notifications on a ' successful ' event, or a '
> failure ' event.  Think of Syserror as a bad name, and consider the event
> as 'System Event'.  If you don't want to be notified when the job
> completes, then remove yourself from getting notified on Successful
> SYSERROR events.  [Operations Page -> Event Definitions to edit].
>
> HTH!
>                                                  -Mike
>
>
>
>
> _______________________________________________
> Opensource mailing list
> Opensource at jcorporate.com
> http://mail.jcorporate.com/mailman/listinfo/opensource
> Archives: http://mail.jcorporate.com/pipermail/opensource/
>