[Opensource] DBMaint fails on second search

[Luis Martin]

Mike,

I've downloaded last version from CVS, and in addition to the lines that
have been commented out, the following ones should also be commented in
DynamicCmd.java:

---8<---------8<---------8<---------8<---------8<---------8
            tempParam = getFieldsParam();

            if (tempParam.length() > 0) {
                searchAction.addParam("fields",
                                      URLUTF8Encoder.encode(tempParam));
            }

            tempParam = getSearchParam();

            if (tempParam.length() > 0) {
                searchAction.addParam("search",
                                      URLUTF8Encoder.encode(tempParam));
            }
---8<---------8<---------8<---------8<---------8<---------8

As a matter of fact, the bug showed up with the search transition.

Thanks for all your fine work.
Luis Martin

----- Original Message -----
From: "Michael Rimov" <rimovm at centercomp.com>
To: <opensource at jcorporate.com>
Sent: Sunday, July 28, 2002 11:40 AM
Subject: Re: [Opensource] DBMaint fails on second search


Luis,

I finally got to look at this and tested it against everything I could
think of, and it seems like a good patch.  Since I didn't create DBMaint
(that was Mike Nash's handiwork), I can't tell if it's legacy parameters or
something for a particular job.  So I've kept it simply commented out if we
find it's causing a different problem later on.

Thanks for catching the bug!
                                                 -Mike



>Modify "showOptions" method in "DynamicCmd.java" so that parameters
"fields"
>and "search" are not added to transitions "Add" and "Search".
>
>I've deleted following lines from the building of "Add" and "Search"
>transitions:
>
>tempParam = getFieldsParam();
>if (tempParam.length() > 0) {
>     addAction.addParam("fields", URLUTF8Encoder.encode(tempParam));
>}
>tempParam = getSearchParam();
>if (tempParam.length() > 0) {
>     addAction.addParam("search", URLUTF8Encoder.encode(tempParam));
>}
>
>I've tested the modification and everything seems to work Ok.
>
>If you are able to initially reproduce the bug and think that the fix is
ok,
>could you include it in CVS ?
>
>Any comments are most welcome.
>
>Best regards,
>Luis Martin
>
>
>----- Original Message -----
>From: "Michael Rimov" <rimovm at centercomp.com>
>To: <opensource at jcorporate.com>
>Sent: Friday, June 14, 2002 6:03 AM
>Subject: Re: [Opensource] DBMaint fails on second search
>
>
>At 08:29 PM 6/10/2002 +0200, you wrote:
> >Hello,
> >
> >DBMaint fails on second search.
> >
> >I'm very new to the Expresso framework, and DBMaint is still far to big
for
> >me to locate the bug. But it can be reproduced taking the following
steps:
> >
> >1) Using DBMaint select table "MIME TYPES" from the General schema.
> >2) Click on "Prompt for search criteria"
> >3) Use "audio%" as filter for the MIME TYPE column and click"Display
>records
> >found by search"
> >4) A listing of 6 records appears.
> >5) Click on the binoculars to perform another search.
> >6) Leave all fields empty and click"Display records found by search" ...
> >Boom
> >No record is selected at all, when it should be retrieving all records.
>
>Luis,
>
>I tried duplicating your bug by following your steps on both MySQL and
>Postgres.  I couldn't get it to blow up like you described.  It's possible
>that in some of the rework that has been going on that it got
>'accidentally' fixed in rewrites.
>
>I encourage you to download the ea-3 when it becomes available and see if
>you still have the problem.  If so, can you please post exactly what
>database you're using?  Thanks!
>
>-Mike (R)
>
>
>
>_______________________________________________
>Opensource mailing list
>Opensource at jcorporate.com
>http://mail.jcorporate.com/mailman/listinfo/opensource
>Archives: http://mail.jcorporate.com/pipermail/opensource/
>
>_______________________________________________
>Opensource mailing list
>Opensource at jcorporate.com
>http://mail.jcorporate.com/mailman/listinfo/opensource
>Archives: http://mail.jcorporate.com/pipermail/opensource/

_______________________________________________
Opensource mailing list
Opensource at jcorporate.com
http://mail.jcorporate.com/mailman/listinfo/opensource
Archives: http://mail.jcorporate.com/pipermail/opensource/