[cvs] expresso commit by lhamel: cosmetic formatting only; introduce string

JCorporate Ltd jcorp at jcorporate.com
Sun Feb 20 22:55:48 UTC 2005


Log Message:
-----------
cosmetic formatting only; introduce string constants

Modified Files:
--------------
    expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/services/dbobj:
        ChangeLog.java

Revision Data
-------------
Index: ChangeLog.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/services/dbobj/ChangeLog.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/services/dbobj/ChangeLog.java -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/services/dbobj/ChangeLog.java -u -r1.12 -r1.13
--- expresso-web/WEB-INF/src/com/jcorporate/expresso/services/dbobj/ChangeLog.java
+++ expresso-web/WEB-INF/src/com/jcorporate/expresso/services/dbobj/ChangeLog.java
@@ -85,8 +85,18 @@
 
 public class ChangeLog
         extends DBObject {
+    public static final String ID = "ChangeKey";
+    public static final String OBJ_CHANGED = "ObjectChanged";
+    public static final String KEY_OF_CHANGED_OBJ = "RecordKey";
+    public static final String OPER_CODE = "Operation";
+    public static final String CHANGED_FIELD = "ChangedField";
+    public static final String CHANGE_TIME = "ChangeTime";
+    public static final String OLD_VALUE = "OldValue";
+    public static final String NEW_VALUE = "NewValue";
+
     /**
      * Constructor
+     *
      * @throws DBException upon construction error.
      */
     public ChangeLog()
@@ -108,6 +118,7 @@
     /**
      * Override of DBObject.add() by setting the changetime to the current
      * date.
+     *
      * @throws DBException upon database creation error.
      */
     public synchronized void add()
@@ -120,7 +131,7 @@
 
          with:
          *RD* Mon Jul 27 2004 */
-        setField("ChangeTime", new Date());
+        setField(CHANGE_TIME, new Date());
         super.add();
 
     } /* add() */
@@ -128,24 +139,25 @@
 
     /**
      * Initializes database setup fields.
+     *
      * @throws DBException
      * @throws DBException upon construction error.
      */
     protected synchronized void setupFields()
             throws DBException {
         setTargetTable("CHANGELOGTWO");
-        addField("ChangeKey", "auto-inc", 0, false, "Changelog Key");
-        addKey("ChangeKey");
+        addField(ID, "auto-inc", 0, false, "Changelog Key");
+        addKey(ID);
 
-        addField("ObjectChanged", "varchar", 40, false, "Object_Changed");
-        addField("RecordKey", "varchar", 150, false, "Key_of_Changed_Object");
-        addField("Operation", "char", 1, false, "Operation_Code");
+        addField(OBJ_CHANGED, "varchar", 40, false, "Object_Changed");
+        addField(KEY_OF_CHANGED_OBJ, "varchar", 150, false, "Key_of_Changed_Object");
+        addField(OPER_CODE, "char", 1, false, "Operation_Code");
 
         /* (A)dd , (D)elete, (U)pdate */
-        addField("ChangedField", "varchar", 40, false, "Field_Changed");
+        addField(CHANGED_FIELD, "varchar", 40, false, "Field_Changed");
 
         /*  (if update) "ALL" for adds & deletes */
-        addField("ChangeTime", "datetime", 0, false, "Time_of_Change");
+        addField(CHANGE_TIME, "datetime", 0, false, "Time_of_Change");
 
 //        addKey("ObjectChanged");
 //        addKey("RecordKey");
@@ -154,13 +166,14 @@
 //        addKey("ChangeTime");
 
 
-        addField("OldValue", "varchar", 255, true, "Old_Field_Value");
-        addField("NewValue", "varchar", 255, true, "New_Field_Value");
+        addField(OLD_VALUE, "varchar", 255, true, "Old_Field_Value");
+        addField(NEW_VALUE, "varchar", 255, true, "New_Field_Value");
     } /* setupFields() */
 
 
     /**
      * Override update to throw exception immediately - no updates allowed
+     *
      * @throws DBException Always.
      */
     public synchronized void update()


More information about the cvs mailing list