[cvs] expresso commit by mtraum: fix broken html rendering
JCorporate Ltd
jcorp at jcorporate.com
Fri Feb 11 18:30:34 UTC 2005
Log Message:
-----------
fix broken html rendering
Modified Files:
--------------
expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html:
ExCheckboxTag.java
ExSelectTag.java
ExSubmitTag.java
ExBaseFieldTag.java
Revision Data
-------------
Index: ExSubmitTag.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSubmitTag.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSubmitTag.java -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSubmitTag.java -u -r1.12 -r1.13
--- expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSubmitTag.java
+++ expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSubmitTag.java
@@ -202,7 +202,8 @@
// Generate an HTML element
StringBuffer results = new StringBuffer();
- results.append("<input type=\"submit\" name=\"");
+ results.append("<input");
+ prepareAttribute( results, "type", "submit");
prepareAttribute( results, "name", "button_" + myTransition.getName() );
// prepareAttribute( results, "", "");
Index: ExCheckboxTag.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExCheckboxTag.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExCheckboxTag.java -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExCheckboxTag.java -u -r1.14 -r1.15
--- expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExCheckboxTag.java
+++ expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExCheckboxTag.java
@@ -138,10 +138,8 @@
if (value == null) {
prepareAttribute( results, "value", "Y" );
- results.append("Y");
} else {
prepareAttribute( results, "value", value );
- results.append(value);
}
results.append("\"");
@@ -152,8 +150,7 @@
checked.equalsIgnoreCase("yes") ||
checked.equalsIgnoreCase("on") || checked.equalsIgnoreCase("y") ||
checked.equalsIgnoreCase(value)) {
- // prepareAttribute( results, "checked", "checked");
- results.append(" checked=\"checked\"");
+ prepareAttribute( results, "checked", "checked");
}
results.append(prepareEventHandlers());
Index: ExBaseFieldTag.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExBaseFieldTag.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExBaseFieldTag.java -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExBaseFieldTag.java -u -r1.13 -r1.14
--- expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExBaseFieldTag.java
+++ expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExBaseFieldTag.java
@@ -178,8 +178,7 @@
}
if (value != null) {
- results.append(value);
- prepareAttribute( results, "value", value );
+ prepareAttribute( results, "value", value );
} else if (redisplay || !"password".equals(type)) {
Object value = myInput.getDefaultValue();
@@ -187,7 +186,6 @@
value = "";
}
- results.append(value.toString());
prepareAttribute( results, "value", value );
}
Index: ExSelectTag.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSelectTag.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSelectTag.java -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSelectTag.java -u -r1.14 -r1.15
--- expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSelectTag.java
+++ expresso-web/WEB-INF/src/com/jcorporate/expresso/ext/struts/taglib/html/ExSelectTag.java
@@ -174,9 +174,6 @@
// Create an appropriate "form" element based on our parameters
StringBuffer results = new StringBuffer("<select");
prepareAttribute( results, "name", myInput.getName() );
- results.append(" name=\"");
- results.append(myInput.getName());
- results.append("\"");
if (accesskey != null) {
prepareAttribute( results, "accesskey", accesskey );
More information about the cvs
mailing list