[cvs]
expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/services/controller
LoginController.java
JCorporate Ltd
jcorp at jcorp2.servlets.net
Wed Sep 8 10:13:47 PDT 2004
Update of /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/services/controller
In directory jcorp2.servlets.net:/tmp/cvs-serv15288/expresso-web/WEB-INF/src/com/jcorporate/expresso/services/controller
Modified Files:
LoginController.java
Log Message:
LoginController.java didn't use the 'corrected' case value for setting session attributes when you have a DB like MySQL that matches username/password with any lower/upper case.
Index: LoginController.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/services/controller/LoginController.java,v
retrieving revision 1.58
retrieving revision 1.59
diff -C2 -d -r1.58 -r1.59
*** LoginController.java 8 Jan 2004 08:09:48 -0000 1.58
--- LoginController.java 8 Sep 2004 17:13:44 -0000 1.59
***************
*** 275,279 ****
request.setUid(uid);
// set params
! setPersistentLoginAttributes(request);
--- 275,279 ----
request.setUid(uid);
// set params
! setPersistentLoginAttributes(request, loginName);
***************
*** 349,360 ****
* should be changed to plug-in model when available in v. 5.1 and thereafter
* @param request The ControllerRequest object for this request
* @throws ControllerException upon error
*/
! public static void setPersistentLoginAttributes(ControllerRequest request) throws ControllerException {
PersistentSession session = request.getSession();
ServletControllerRequest sHreq = (ServletControllerRequest) request;
HttpServletRequest hreq = sHreq.getHttpServletRequest();
! session.setPersistentAttribute("UserName", request.getParameter("LoginName"));
session.setPersistentAttribute("Password", request.getParameter("Password"));
session.setPersistentAttribute("db", request.getDataContext());
--- 349,361 ----
* should be changed to plug-in model when available in v. 5.1 and thereafter
* @param request The ControllerRequest object for this request
+ * @param loginName the login name which has been (potentially) corrected to match case in DB, even if DB matches on any lower/upper case
* @throws ControllerException upon error
*/
! public static void setPersistentLoginAttributes(ControllerRequest request, String loginName) throws ControllerException {
PersistentSession session = request.getSession();
ServletControllerRequest sHreq = (ServletControllerRequest) request;
HttpServletRequest hreq = sHreq.getHttpServletRequest();
! session.setPersistentAttribute("UserName", loginName);
session.setPersistentAttribute("Password", request.getParameter("Password"));
session.setPersistentAttribute("db", request.getDataContext());
***************
*** 365,369 ****
try {
myLogin = CurrentLogin.newInstance(GenericSession.getId(hreq),
! request.getParameter("LoginName"),
hreq.getRemoteAddr(),
request.getDataContext(),
--- 366,370 ----
try {
myLogin = CurrentLogin.newInstance(GenericSession.getId(hreq),
! loginName,
hreq.getRemoteAddr(),
request.getDataContext(),
More information about the cvs
mailing list