[cvs] expresso commit by lhamel: remove unused try/catch

JCorporate Ltd jcorp at jcorp2.servlets.net
Tue Oct 19 23:33:14 PDT 2004


Log Message:
-----------
remove unused try/catch

Modified Files:
--------------
    expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/core/controller:
        ControllerInstallLog.java

Revision Data
-------------
Index: ControllerInstallLog.java
===================================================================
RCS file: /home/javacorp/.cvs/expresso/expresso/expresso-web/WEB-INF/src/com/jcorporate/expresso/core/controller/ControllerInstallLog.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/core/controller/ControllerInstallLog.java -Lexpresso-web/WEB-INF/src/com/jcorporate/expresso/core/controller/ControllerInstallLog.java -u -r1.4 -r1.5
--- expresso-web/WEB-INF/src/com/jcorporate/expresso/core/controller/ControllerInstallLog.java
+++ expresso-web/WEB-INF/src/com/jcorporate/expresso/core/controller/ControllerInstallLog.java
@@ -87,7 +87,6 @@
  * </p>
  * first before using the log or
  * @author Michael Rimov
- * @version $Revision$ on  $Date$
  * @see com.jcorporate.expresso.kernel.InstallLog
  * @see com.jcorporate.expresso.kernel.ConsoleInstallLog
  */
@@ -101,7 +100,7 @@
     /**
      * Constructs a ControllerInstallLog and sets the ControllerResponse that
      * we will be using to add the outputs to.
-     * @param response
+     * @param theResponse
      */
     public ControllerInstallLog(ControllerResponse theResponse) {
         response = theResponse;
@@ -129,7 +128,6 @@
      * Helper method that adds the output to either the parent block
      * or the controller response, depending on what was needed
      * @param logMessage the output to add
-     * @throws ControllerException upon error
      */
     protected void addOutput(Output logMessage)  {
         try {
@@ -217,18 +215,9 @@
      * @param error the exception to log as well.
      */
     protected void addNestedOutputs(Output o, Throwable error) {
-        try {
             ByteArrayOutputStream bos = new ByteArrayOutputStream();
             error.printStackTrace(new PrintStream(bos));
             o.addNested(new Output("stackTrace",bos.toString()));
             o.addNested(new Output("errorMessage", error.getMessage()));
-        }
-        catch (ControllerException ex) {
-            log.warn("Error logging install message", ex);
-            log.warn("Original exception to log: " , error);
-
-        }
-
     }
-
 }


More information about the cvs mailing list